Skip to content

Added SharpDX Direct2D sample #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
shmuelie wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Added SharpDX Direct2D sample #13

shmuelie wants to merge 10 commits into from

Conversation

@shmuelie
Copy link

@shmuelie shmuelie commented Nov 16, 2015

No description provided.

@msftclas
Copy link

msftclas commented Nov 16, 2015

Hi @SamuelEnglard, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.microsoft.com.

TTYL, MSBOT;

@msftclas
Copy link

msftclas commented Nov 16, 2015

@SamuelEnglard, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.

Thanks, MSBOT;

rrelyea
rrelyea reviewed Nov 20, 2015
View reviewed changes
samples/SharpDx2D/MainWindow.xaml.cs
Copy link
Contributor

@rrelyea rrelyea Nov 20, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would it be better to use MainImage, instead of the parent grid. So people can add things to the page, and still work fine.

Copy link
Author

@shmuelie shmuelie Nov 23, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Problem is that Image sizes itself based on the image so it has no size until the image has size

@rrelyea
Copy link
Contributor

rrelyea commented Nov 20, 2015

Can we have a readme, or the like, so people understand the requirements (compile time, run time on a user machine, etc...) to run the sample?

@shmuelie
Copy link
Author

shmuelie commented Nov 23, 2015

Added the spaces and a README

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@shmuelie @msftclas @rrelyea @msftgits